D13372: Mouse KCM Redesign Using Kirigami

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:32
> -    property size sizeHint: Qt.size(maincol.width, maincol.height)
> -    property size minimumSizeHint: Qt.size(maincol.width/2, deviceSelector.height)
>      property alias deviceIndex: deviceSelector.currentIndex

Please re-add the `minimumSizeHint` line so that the window sizes itself properly when run with `kcmshell5 mouse`.

> main_deviceless.qml:32
> -    property size sizeHint: Qt.size(maincol.width, Math.round(1.1 * maincol.height))
> -    property size minimumSizeHint: Qt.size(maincol.width, Math.round(1.1 * maincol.height))
>      signal changeSignal()

Please re-add the `minimumSizeHint` line so that the window sizes itself properly when run with `kcmshell5 mouse`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg, mart
Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180610/012c95dd/attachment.html>