<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13372">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13372#inline-70309">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">sizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">minimumSizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">,</span> <span style="color: #004012">deviceSelector</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span style="color: #aa4000">deviceIndex:</span> <span style="color: #004012">deviceSelector</span><span class="p">.</span><span style="color: #004012">currentIndex</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please re-add the <tt style="background: #ebebeb; font-size: 13px;">minimumSizeHint</tt> line so that the window sizes itself properly when run with <tt style="background: #ebebeb; font-size: 13px;">kcmshell5 mouse</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13372#inline-70308">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main_deviceless.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">sizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #601200">1.1</span> <span style="color: #aa2211">*</span> <span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">minimumSizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #601200">1.1</span> <span style="color: #aa2211">*</span> <span style="color: #004012">maincol</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">signal</span> <span style="color: #004012">changeSignal</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please re-add the <tt style="background: #ebebeb; font-size: 13px;">minimumSizeHint</tt> line so that the window sizes itself properly when run with <tt style="background: #ebebeb; font-size: 13px;">kcmshell5 mouse</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13372">https://phabricator.kde.org/D13372</a></div></div><br /><div><strong>To: </strong>furkantokac, ngraham, romangg, mart<br /><strong>Cc: </strong>safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>