D13194: Use the new drag handle in the Language KCM

Eike Hein noreply at phabricator.kde.org
Fri Jun 8 00:00:53 UTC 2018


hein added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:77
> this explicit reparenting shouldn't be necessary (and breaks in my branch for multi level kcms)

I've told you a few times now that it's been necessary for me so far, since the sheet doesn't appear or in bizarre locations otherwise. Did you test?

> mart wrote in main.qml:98
> is this width: necessary?

I added it because you told me several times that it's necessary now. You tell me?

> mart wrote in main.qml:184
> this shouldn't be necessary

I'll remove it soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180608/12b939a5/attachment-0001.html>


More information about the Plasma-devel mailing list