D13194: Use the new drag handle in the Language KCM

Marco Martin noreply at phabricator.kde.org
Thu Jun 7 10:24:44 UTC 2018


mart added inline comments.

INLINE COMMENTS

> main.qml:77
>  
>          parent: root.parent
>  

this explicit reparenting shouldn't be necessary (and breaks in my branch for multi level kcms)

> main.qml:98
> +            delegate: Kirigami.DelegateRecycler {
> +                width: parent.width
>  

is this width: necessary?

> main.qml:184
>              contentItem: RowLayout {
>                  width: implicitWidth
>  

this shouldn't be necessary

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180607/d56cb409/attachment.html>


More information about the Plasma-devel mailing list