D13390: Fonts KCM: Fix text readability regression

Henrik Fehlauer noreply at phabricator.kde.org
Thu Jun 7 11:34:59 UTC 2018


rkflx added a comment.


  In D13390#275153 <https://phabricator.kde.org/D13390#275153>, @mart wrote:
  
  > what you should do is:
  >  TextField {
  >
  >   readOnly: true
  >   Kirigami.Theme.inherit: false   //always to be set when you are writing anything to the Theme attached proeprty
  >   Kirigami.Theme.colorGroup: Kirigami.Theme.Window
  >
  > }
  >
  > changing the textfield colorgroup to window, will make its background to become gray, so a look somewhat less "clickable"
  
  
  Now it looks as if you can edit the text, and the previews are placeholders for what you can type in:
  
  F5895669: fonts-kcm-kirigami.png <https://phabricator.kde.org/F5895669>
  
  IMO that's worse.
  
  In D13390#275119 <https://phabricator.kde.org/D13390#275119>, @broulik wrote:
  
  > What works for me is doing `root.Kirigami.Theme.textColor` which arguably isn't a lot better since it won't use button context but view context but I don't like having a random `SystemPalette` item in there.
  
  
  Let me know if I should go in that direction. It's a bit ugly as it assumes `root` is in `enabled` state, but at least it works.
  
  (I miss good old `KFontRequester`.)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13390

To: rkflx
Cc: mart, broulik, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180607/b704e0d2/attachment-0001.html>


More information about the Plasma-devel mailing list