D13367: Improve the clarity and presentation of the update details text field

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jun 6 14:04:10 UTC 2018


broulik added inline comments.

INLINE COMMENTS

> PackageKitResource.cpp:222
>      foreach(const QString& pkgid, pkgids) {
> -        ret += i18nc("package-name (version)", "%1 (%2)", PackageKit::Daemon::packageName(pkgid), PackageKit::Daemon::packageVersion(pkgid));
> +        ret += i18nc("package-name version", "%1", PackageKit::Daemon::packageVersion(pkgid));
>      }

You don't need the `i18nc` at all anymore as you just forward the string verbatim

REPOSITORY
  R134 Discover Software Store

BRANCH
  clearer-update-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13367

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180606/564975d5/attachment.html>


More information about the Plasma-devel mailing list