<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13367">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13367#inline-69750">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PackageKitResource.cpp:222</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">pkgid</span><span class="p">,</span> <span class="n">pkgids</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">ret</span> <span style="color: #aa2211">+=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"package-name <span class="bright">(</span>version<span class="bright">)</span>"</span><span class="p">,</span> <span style="color: #766510">"%1<span class="bright"> (%2)"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">PackageKit</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Daemon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">packageName</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">pkgid</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>,</span> <span class="n">PackageKit</span><span style="color: #aa2211">::</span><span class="n">Daemon</span><span style="color: #aa2211">::</span><span class="n">packageVersion</span><span class="p">(</span><span class="n">pkgid</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ret</span> <span style="color: #aa2211">+=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"package-name version"</span><span class="p">,</span> <span style="color: #766510">"%1<span class="bright">"</span></span><span class="p">,</span> <span class="n">PackageKit</span><span style="color: #aa2211">::</span><span class="n">Daemon</span><span style="color: #aa2211">::</span><span class="n">packageVersion</span><span class="p">(</span><span class="n">pkgid</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You don't need the <tt style="background: #ebebeb; font-size: 13px;">i18nc</tt> at all anymore as you just forward the string verbatim</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>BRANCH</strong><div><div>clearer-update-text (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13367">https://phabricator.kde.org/D13367</a></div></div><br /><div><strong>To: </strong>ngraham, apol, Discover Software Store<br /><strong>Cc: </strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>