D13361: Allow Compact view with narrower windows

Nathaniel Graham noreply at phabricator.kde.org
Tue Jun 5 13:04:34 UTC 2018


ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When the width of the sidebar was reduced, I didn't change the threshold at which the window uses Compact View when it becomes narrower. As a result, Compact View was almost never used in desktop mode, because the threshold at which it triggered was close to the threshold at which the window changes over to mobile view.
  
  This patch corrects the issue and allows the window to switch to Compact View more often.

TEST PLAN
  Discover's main window can now be made small and narrow and it will switch more quickly to Compact view:

REPOSITORY
  R134 Discover Software Store

BRANCH
  allow-compact-view-with-narrower-windows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13361

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml

To: ngraham, apol, #discover_software_store
Cc: sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180605/406fcb1f/attachment.html>


More information about the Plasma-devel mailing list