D13325: Don't bother loading on non-supported platforms
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jun 4 06:47:18 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Chrome syncs installed extensions across computers and will install it also on Windows, macOS and other unsupported platforms.
This would yield a "Make sure p-b-i package is installed" on startup the user can do nothing about.
TEST PLAN
5.13 branch
- Still works fine on Linux in Chrome and Firefox
- Added a typo to "linux" in `SUPPORTED_PLATFORMS`, would not try to connect to host. Didn't actually test on real Windows
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13325
AFFECTED FILES
extension/constants.js
extension/extension.js
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180604/a2fbcd08/attachment.html>
More information about the Plasma-devel
mailing list