D14389: Invert shade button by same logic as keep-above button

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, the issue here is that unlike the Keep Above button, the Shade button actually changes its icon when used. So it's not so much a "shade enabled/shade disabled" button, as it is a "shade/unshade" button. Do you see the difference? One tracks state ("is shade mode enabled?"), the other one expresses distinct actions ("shade the window!" "un-shade the window!"). I would want that harmonized with the Keep Above button so they both behave in the same way first before accepting this patch, because otherwise people will file bugs saying "The Keep Above button doesn't change its icon when it's turned on the way the Shade button does!"

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14389

To: andykluger, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180726/980b24d8/attachment.html>