D14050: Fwupd Backend For Review and Improvement

[Abhijeet sharma]

abhijeet2096 marked 18 inline comments as done.
abhijeet2096 added a comment.


  Still, Need to implement Notification Class and some functions in Updater Class. I have to see if we could use the standard Updater Class, after Confirmation I will use directly FwupdResource instead of abstract resource

INLINE COMMENTS

> apol wrote in SourcesPage.qml:113
> Remove unrelated patch

Actually, I modified this file to show EULA on setting page.

> anthonyfieroni wrote in FwupdBackend.cpp:85
> It's memory leak.

Please see the new modified function. Will Memory be leaking?

> apol wrote in FwupdBackend.cpp:100
> No need to cast. Use the FwupdResource directly.

Still Need To Fix it

> apol wrote in FwupdNotifier.cpp:37
> Don't add one that does nothing.
> Either implement it or just don't add it.

Need to Implement it, Like Updates which require Restart. Will Implement it.

> anthonyfieroni wrote in FwupdSourcesBackend.cpp:75-77
> ?

Here, The UI gets Updates first. The CheckBox fills first then its applied at the backend. Need a way to control the checkbox UI

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14050

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180715/5fa2e6db/attachment-0001.html>