D14050: Fwupd Backend For Review and Improvement

Abhijeet sharma noreply at phabricator.kde.org
Sun Jul 15 04:06:00 BST 2018


abhijeet2096 updated this revision to Diff 37778.
abhijeet2096 added a comment.


  Following Updates are made:
  
  - Removed Unnecessary Dependencies
  - Now All strings are constructed by QString
  - Regularized the indentation and coding style
  - Removed the soup headers, Now QT libs are used to Download files
  - QT based Hash Function is used to calculate Hash
  - Removed the Category File
  - Removed The Review Backend Completely
  - Added Dependencies of soup, glib and GIO inside FINDLIBFWUPD.cmake
  - QUrl and QFile is Now Used
  - Added Checks at Various Places

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14050?vs=37580&id=37778

REVISION DETAIL
  https://phabricator.kde.org/D14050

AFFECTED FILES
  CMakeLists.txt
  cmake/FindGIO.cmake
  cmake/FindGLib.cmake
  cmake/FindGObject.cmake
  cmake/FindGObjectIntrospection.cmake
  cmake/FindLIBFWUPD.cmake
  cmake/FindSoup.cmake
  discover/qml/SourcesPage.qml
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/FwupdBackend/CMakeLists.txt
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h
  libdiscover/backends/FwupdBackend/FwupdNotifier.cpp
  libdiscover/backends/FwupdBackend/FwupdNotifier.h
  libdiscover/backends/FwupdBackend/FwupdResource.cpp
  libdiscover/backends/FwupdBackend/FwupdResource.h
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h
  libdiscover/backends/FwupdBackend/FwupdTransaction.cpp
  libdiscover/backends/FwupdBackend/FwupdTransaction.h
  libdiscover/backends/FwupdBackend/FwupdUpdater.cpp
  libdiscover/backends/FwupdBackend/FwupdUpdater.h
  libdiscover/backends/FwupdBackend/tests/CMakeLists.txt
  libdiscover/backends/FwupdBackend/tests/FwupdTest.cpp
  libdiscover/backends/FwupdBackend/tests/FwupdTest.h
  libdiscover/backends/FwupdBackend/tests/UpdateFwupdTest.cpp
  libdiscover/resources/AbstractSourcesBackend.h

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180715/53e388dd/attachment.html>


More information about the Plasma-devel mailing list