D13931: [KCM] Add speaker placement test

Nicolas Fella noreply at phabricator.kde.org
Sat Jul 14 11:41:04 BST 2018


nicolasfella updated this revision to Diff 37735.
nicolasfella marked 9 inline comments as done.
nicolasfella added a comment.


  - Fix unref'ing
  - Save context in variable
  - Fix * placement
  - Fix QML style

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13931?vs=37660&id=37735

BRANCH
  speakertest

REVISION DETAIL
  https://phabricator.kde.org/D13931

AFFECTED FILES
  src/CMakeLists.txt
  src/canberracontext.cpp
  src/canberracontext.h
  src/kcm/package/contents/ui/Advanced.qml
  src/qml/volumefeedback.cpp
  src/qml/volumefeedback.h
  src/sink.cpp
  src/sink.h

To: nicolasfella, drosca
Cc: ngraham, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180714/c705fd40/attachment-0001.html>


More information about the Plasma-devel mailing list