D14050: Fwupd Backend For Review and Improvement

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> FwupdBackend.cpp:272-289
> +            FwupdDevice *device = (FwupdDevice *)g_ptr_array_index (devices, i);
> +            FwupdResource* res;
> +
> +           res = FwupdCreateDevice(device); //just to test code should be deleted
> +           m_toUpdate.append(res); //just to test code should be deleted
> +
> +            if (!fwupd_device_has_flag (device, FWUPD_DEVICE_FLAG_SUPPORTED))

Coding style nitpick: indentation is not consistent. At all.

> FwupdBackend.cpp:294-308
> +            if (rels == NULL) {
> +                if (g_error_matches (error2,FWUPD_ERROR,FWUPD_ERROR_NOTHING_TO_DO)){
> +                    qWarning() << "No Packages Found for "<< fwupd_device_get_id(device);
> +                    FwupdHandleError(&error2);
> +                    continue;
> +                }
> +            }

Coding style nitpick: why does this small piece of code follows several totally different coding styles?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14050

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180711/0ea49f5c/attachment-0001.html>