<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14050">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14050#inline-73897">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FwupdBackend.cpp:272-289</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="n">device</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="p">)</span><span class="n">g_ptr_array_index</span> <span class="p">(</span><span class="n">devices</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">FwupdResource</span><span style="color: #aa2211">*</span> <span class="n">res</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">           <span class="n">res</span> <span style="color: #aa2211">=</span> <span class="n">FwupdCreateDevice</span><span class="p">(</span><span class="n">device</span><span class="p">);</span> <span style="color: #74777d">//just to test code should be deleted</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">           <span class="n">m_toUpdate</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">res</span><span class="p">);</span> <span style="color: #74777d">//just to test code should be deleted</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">fwupd_device_has_flag</span> <span class="p">(</span><span class="n">device</span><span class="p">,</span> <span class="n">FWUPD_DEVICE_FLAG_SUPPORTED</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style nitpick: indentation is not consistent. At all.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14050#inline-73896">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FwupdBackend.cpp:294-308</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">rels</span> <span style="color: #aa2211">==</span> <span style="color: #304a96">NULL</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">g_error_matches</span> <span class="p">(</span><span class="n">error2</span><span class="p">,</span><span class="n">FWUPD_ERROR</span><span class="p">,</span><span class="n">FWUPD_ERROR_NOTHING_TO_DO</span><span class="p">)){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">qWarning</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"No Packages Found for "</span><span style="color: #aa2211"><<</span> <span class="n">fwupd_device_get_id</span><span class="p">(</span><span class="n">device</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">FwupdHandleError</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">error2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">continue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style nitpick: why does this small piece of code follows several totally different coding styles?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14050">https://phabricator.kde.org/D14050</a></div></div><br /><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: </strong>zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>