D13907: [SDDM Theme] Set sourceSize on background image

[David Edmundson]

davidedmundson added a comment.


  > Actually increases ram usage of sddm-greeter by 10 MiB here. I thought it would never load the image larger than it is? :/
  
  It won't. Maybe you're testing wrong.

INLINE COMMENTS

> Background.qml:37-38
>          id: sceneImageBackground
> -        anchors.fill: parent
> +        width: parent.width
> +        height: parent.height
>          fillMode: Image.PreserveAspectCrop

no need to change this

> Background.qml:41
>          smooth: true;
> +        sourceSize: Qt.size(width * Screen.devicePixelRatio, height * Screen.devicePixelRatio)
>      }

Multiplying by devicePixelRatio seems wrong.

From QQuickImageBase:

  d->pix.load(qmlEngine(this), loadUrl, d->sourcesize * d->devicePixelRatio, options, d->providerOptions);

but code there is a bit more complex

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13907

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180706/4409defd/attachment.html>