D13881: oxygen-demo : add KMessage preview

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jul 4 14:28:43 BST 2018


broulik added inline comments.

INLINE COMMENTS

> rjvbb wrote in oxygenframedemowidget.cpp:90
> That's to catch the event sent to the qApp instance when the theme is changed (to be exact: after KColorSchemeManager sets or changes the `KDE_COLOR_SCHEME_PATH` property.
> 
> Without this, the messages don't adapt to reflect the new colours (even the current implementation mixes the window background into its background colour).

I think you're working around a bug here. `KColorSchemeManager` does

  qApp->setPalette(KColorScheme::createApplicationPalette(KSharedConfig::openConfig(action->data().toString())));

so the `KMessageWidget` should get a `PaletteChange` event and adjust, if not, it's a bug there.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D13881

To: rjvbb, hpereiradacosta
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180704/38d1587f/attachment.html>


More information about the Plasma-devel mailing list