D13881: oxygen-demo : add KMessage preview

René J.V. Bertin noreply at phabricator.kde.org
Wed Jul 4 12:46:46 BST 2018


rjvbb created this revision.
rjvbb added a reviewer: hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
rjvbb requested review of this revision.

REVISION SUMMARY
  A recent change to the `KMessageWidget` look has caught my interest and made me start to experiment with ways to make them integrate better, in particular concerning the use of colour (see D13777 <https://phabricator.kde.org/D13777> and recent posts on the frameworks-devel ML).
  
  This patch adds a preview of the 4 different KMessageWidget types to what I think is the most appropriate existing widget, plus the magic required for detecting and reacting to colour theme changes.
  
  This change makes testing a new look across all installed colour themes and widget styles much easier. Idem for assessing just how well the current design really works, of course.

TEST PLAN
  Works as intended.
  
  Possible improvements:
  
  - add a dedicated frame/tab that could show other, comparable widgets (but which?)
  - add a signal to `ColorSchemeChooser` (but is that better than handling the QEvent it already triggers?)

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D13881

AFFECTED FILES
  kstyle/demo/oxygenframedemowidget.cpp
  kstyle/demo/oxygenframedemowidget.h

To: rjvbb, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180704/18914565/attachment.html>


More information about the Plasma-devel mailing list