<table><tr><td style="">rjvbb created this revision.<br />rjvbb added a reviewer: hpereiradacosta.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />rjvbb requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13881">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>A recent change to the <tt style="background: #ebebeb; font-size: 13px;">KMessageWidget</tt> look has caught my interest and made me start to experiment with ways to make them integrate better, in particular concerning the use of colour (see <a href="https://phabricator.kde.org/D13777" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13777</a> and recent posts on the frameworks-devel ML).</p>
<p>This patch adds a preview of the 4 different KMessageWidget types to what I think is the most appropriate existing widget, plus the magic required for detecting and reacting to colour theme changes.</p>
<p>This change makes testing a new look across all installed colour themes and widget styles much easier. Idem for assessing just how well the current design really works, of course.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Works as intended.</p>
<p>Possible improvements:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">add a dedicated frame/tab that could show other, comparable widgets (but which?)</li>
<li class="remarkup-list-item">add a signal to <tt style="background: #ebebeb; font-size: 13px;">ColorSchemeChooser</tt> (but is that better than handling the QEvent it already triggers?)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R113 Oxygen Theme</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13881">https://phabricator.kde.org/D13881</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kstyle/demo/oxygenframedemowidget.cpp<br />
kstyle/demo/oxygenframedemowidget.h</div></div></div><br /><div><strong>To: </strong>rjvbb, hpereiradacosta<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>