D10060: Enable blending if a subsurface has an alpha channel

[Roman Gilg]

romangg added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> scene_opengl.cpp:1383
>          texture->render(region, QRect(0, 0, texture->width() / scale, texture->height() / scale), hardwareClipping);
>          texture->unbind();
>      }

Disable blend again in case it was enabled for this subsurface but following ones have no alpha?

> scene_opengl.cpp:1518
>  
> -    setBlendEnabled(false);
> -

Wouldn't you like to leave this here? Otherwise blend might be enabled depending on the last node through
`nodes[i].hasAlpha || nodes[i].opacity < 1.0`
in the previous loop even when no subsurface has alpha.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10060

To: graesslin, #kwin, #plasma
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180123/846c1ce6/attachment.html>