<table><tr><td style="">romangg added inline comments.<br />Restricted Application edited projects, added KWin; removed Plasma.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10060" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10060#inline-46183" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_opengl.cpp:1383</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">texture</span><span style="color: #aa2211">-></span><span class="n">render</span><span class="p">(</span><span class="n">region</span><span class="p">,</span> <span class="n">QRect</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">texture</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">scale</span><span class="p">,</span> <span class="n">texture</span><span style="color: #aa2211">-></span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">scale</span><span class="p">),</span> <span class="n">hardwareClipping</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">texture</span><span style="color: #aa2211">-></span><span class="n">unbind</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Disable blend again in case it was enabled for this subsurface but following ones have no alpha?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10060#inline-46179" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_opengl.cpp:1518</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">setBlendEnabled</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't you like to leave this here? Otherwise blend might be enabled depending on the last node through<br />
<tt style="background: #ebebeb; font-size: 13px;">nodes[i].hasAlpha || nodes[i].opacity < 1.0</tt><br />
in the previous loop even when no subsurface has alpha.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10060" rel="noreferrer">https://phabricator.kde.org/D10060</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>