D7246: Tooltips

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I get compile errors:
  
    /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp: In member function ‘virtual std::unique_ptr<KDecoration2::DecoratedClientPrivate> MockBridge::createClient(KDecoration2::DecoratedClient*, KDecoration2::Decoration*)’:
    /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:27:77: error: invalid new-expression of abstract class type ‘MockClient’
         auto ptr = std::unique_ptr<MockClient>(new MockClient(client, decoration));
                                                                                 ^
    In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21:0:
    /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:27:7: note:   because the following virtual functions are pure within ‘MockClient’:
     class MockClient : public QObject, public KDecoration2::ApplicationMenuEnabledDecoratedClientPrivate
           ^~~~~~~~~~
    In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:23:0,
                     from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21:
    /home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:79:18: note:   virtual void KDecoration2::DecoratedClientPrivate::requestShowToolTip(const QString&)
         virtual void requestShowToolTip(const QString &text) = 0;
                      ^~~~~~~~~~~~~~~~~~
    /home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:80:18: note:   virtual void KDecoration2::DecoratedClientPrivate::requestHideToolTip()
         virtual void requestHideToolTip() = 0;
                      ^~~~~~~~~~~~~~~~~~
    [ 72%] Building CXX object autotests/CMakeFiles/decorationButtonTest.dir/mockdecoration.cpp.o
    autotests/CMakeFiles/decorationTest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o' failed
    make[2]: *** [autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180116/ed7bf3d6/attachment.html>