<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7246" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I get compile errors:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp: In member function ‘virtual std::unique_ptr<KDecoration2::DecoratedClientPrivate> MockBridge::createClient(KDecoration2::DecoratedClient*, KDecoration2::Decoration*)’:
/home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:27:77: error: invalid new-expression of abstract class type ‘MockClient’
     auto ptr = std::unique_ptr<MockClient>(new MockClient(client, decoration));
                                                                             ^
In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21:0:
/home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:27:7: note:   because the following virtual functions are pure within ‘MockClient’:
 class MockClient : public QObject, public KDecoration2::ApplicationMenuEnabledDecoratedClientPrivate
       ^~~~~~~~~~
In file included from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockclient.h:23:0,
                 from /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp:21:
/home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:79:18: note:   virtual void KDecoration2::DecoratedClientPrivate::requestShowToolTip(const QString&)
     virtual void requestShowToolTip(const QString &text) = 0;
                  ^~~~~~~~~~~~~~~~~~
/home/martin/src/kf5/kde/workspace/kdecoration/autotests/../src/private/decoratedclientprivate.h:80:18: note:   virtual void KDecoration2::DecoratedClientPrivate::requestHideToolTip()
     virtual void requestHideToolTip() = 0;
                  ^~~~~~~~~~~~~~~~~~
[ 72%] Building CXX object autotests/CMakeFiles/decorationButtonTest.dir/mockdecoration.cpp.o
autotests/CMakeFiles/decorationTest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o' failed
make[2]: *** [autotests/CMakeFiles/decorationTest.dir/mockbridge.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....</pre></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7246" rel="noreferrer">https://phabricator.kde.org/D7246</a></div></div><br /><div><strong>To: </strong>McPain, Breeze, Plasma, graesslin<br /><strong>Cc: </strong>cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, Breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>