D9914: [Folder View] Don't trash local files

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Send the actual URL (e.g. `desktop:/foo`) to KIO and let it figure it out. Otherwise `KDirNotify` emits a change for the backing `file:///home/foo/Desktop` URL and `KDirLister` cannot relate the two and doesn't notice a deletion immediately.
  Since we don't offer "Move to Trash" for non-local files anyway, this should be safe.

TEST PLAN
  This fixes files being moved to trash from the desktop taking half a second, now it's instant.
  
  While at it, check for whether files can be moved before offering Trash and wehther files can be deleted before offering Delete (Dolphin does that). I can split that into a separate commit, if you prefer.
  
  Hitting "Delete" key on a remote file will show "access denied" but that's a different issue as FolderView does not (iirc that was done on purpose) automatically fall back to "Delete" when "Move to Trash" is unavailable as Dolphin would.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9914

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180116/04a70d2a/attachment.html>