<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, hein.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9914" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Send the actual URL (e.g. <tt style="background: #ebebeb; font-size: 13px;">desktop:/foo</tt>) to KIO and let it figure it out. Otherwise <tt style="background: #ebebeb; font-size: 13px;">KDirNotify</tt> emits a change for the backing <tt style="background: #ebebeb; font-size: 13px;">file:///home/foo/Desktop</tt> URL and <tt style="background: #ebebeb; font-size: 13px;">KDirLister</tt> cannot relate the two and doesn't notice a deletion immediately.<br />
Since we don't offer "Move to Trash" for non-local files anyway, this should be safe.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>This fixes files being moved to trash from the desktop taking half a second, now it's instant.</p>
<p>While at it, check for whether files can be moved before offering Trash and wehther files can be deleted before offering Delete (Dolphin does that). I can split that into a separate commit, if you prefer.</p>
<p>Hitting "Delete" key on a remote file will show "access denied" but that's a different issue as FolderView does not (iirc that was done on purpose) automatically fall back to "Delete" when "Move to Trash" is unavailable as Dolphin would.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9914" rel="noreferrer">https://phabricator.kde.org/D9914</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp<br />
containments/desktop/plugins/folder/foldermodel.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>