D9892: cmake: Use the official CMake variable for building as a static plugin.

Emmanuel Lepage Vallee noreply at phabricator.kde.org
Tue Jan 16 00:30:20 UTC 2018


lepagevalleeemmanuel added a comment.


  In https://phabricator.kde.org/D9892#191590, @apol wrote:
  
  > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?
  
  
  (this code is originally from me, then improved by notmart and is part of the greater work to ship static appimages)
  
  I did consider it and went ahead in ring-kde and put every QML in QRC even in non static builds. I think it makes sense, but makes debugging a bit harder and I didn't want to change too much things to fix the static plugin. Shipping assets in QRC doesn't seem to be common outside of some KDE projects that take cross platform more seriously.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9892

To: mart, #kirigami, lepagevalleeemmanuel
Cc: apol, plasma-devel, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180116/17be50c2/attachment.html>


More information about the Plasma-devel mailing list