D9892: cmake: Use the official CMake variable for building as a static plugin.

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it?

INLINE COMMENTS

> CMakeLists.txt:47
> +    set_target_properties(kirigamiplugin PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2)
> +    target_link_libraries(kirigamiplugin
> +        PUBLIC

I'd reuse the target_link_libraries calls. Better duplicate minimum. You can have an extra target_link_libraries(kirigamiplugin PRIVATE KF5::Kirigami2) if needed.

> qmldir:2
>  module org.kde.kirigami
> -plugin kirigamiplugin
> +#plugin kirigamiplugin
>  classname KirigamiPlugin

Why is it commented?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D9892

To: mart, #kirigami, lepagevalleeemmanuel
Cc: apol, plasma-devel, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180116/05404191/attachment.html>