D9792: even slimmer scrollbars

Marco Martin noreply at phabricator.kde.org
Mon Jan 15 10:23:04 UTC 2018


mart added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:5016
> Ok. Just checked: this whole code should still work if replaced by:
> 
>   const bool widgetMouseOver( _animations->scrollBarEngine().isHovered( widget, QStyle::SC_ScrollBarGroove ) );
> 
> (used elsewhere also)
> it relies on the fact that hover state is properly updated, which seems to be the case, at least with QWidget.
> Can you double check with QtQuick ? If yes, that would be a nice replacement.

it works ok for the qwidget case, unfortunately in the case of qml, _animations will always be empty, so i still have to check option->styleObject anyways

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D9792

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180115/d155751a/attachment-0001.html>


More information about the Plasma-devel mailing list