D9792: even slimmer scrollbars

Hugo Pereira Da Costa noreply at phabricator.kde.org
Sun Jan 14 17:21:04 UTC 2018


hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:5016
> +        // in case this QStyle is used by QQuickControls QStyle wrapper
> +        else if( option->styleObject ) widgetMouseOver = option->styleObject->property("hover").toBool();
> +

Ok. Just checked: this whole code should still work if replaced by:

  const bool widgetMouseOver( _animations->scrollBarEngine().isHovered( widget, QStyle::SC_ScrollBarGroove ) );

(used elsewhere also)
it relies on the fact that hover state is properly updated, which seems to be the case, at least with QWidget.
Can you double check with QtQuick ? If yes, that would be a nice replacement.

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D9792

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180114/8fa0d9e1/attachment.html>


More information about the Plasma-devel mailing list