D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Fabian Vogt]

fvogt added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9873#190789, @graesslin wrote:
  
  > I wasn't aware of this secure_getenv functionality.
  
  
  Me neither...
  
  > Is that also in place after the process has completely dropped all privs?
  
  Quote from `man 3 secure_getenv`:
  
  > the effective capability bit was set on the executable file
  
  so, yes.

INLINE COMMENTS

> graesslin wrote in xkb.h:121-127
> as both do not operate on anything of the Xkb class I would move them out of the class and put them into an anonymous namespace.

Would just moving them outside of the class as `static` functions within xkb.cpp work for you as well?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9873

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180114/e3c0c6b7/attachment-0001.html>