D9792: even slimmer scrollbars

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi,
  
  That looks nice. I don't think it needs a separate settings, since once again the hit area is the same as before. 
  Then: would be nice to have VDG oppinion on that, and see if we can make the code less hackish (on the mouse-over detection side).
  
  Hugo

INLINE COMMENTS

> breezestyle.cpp:5041
> +        if( grooveOpacity == AnimationData::OpacityInvalid ) grooveOpacity = (widgetMouseOver ? 1 : 0);
> +
>          const auto mode( _animations->scrollBarEngine().animationMode( widget, SC_ScrollBarSlider ) );

This whole code feels hackish.
In principle we know (elsewhere in the code), if any part of the scrollbar is hovered, since it is used to make the groove appear. 
I checked that this is done in a separate method though, namely Breeze::Style::drawScrollBarComplexControl, which calls the base class method in the end, which in turn ends up calling this method. 
I wonder if we should not simply move the code from drawScrollbarSliderControl to the ComplexControl method, thus making the hacking above unnecessary. (makes sense ?)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180110/5243f365/attachment-0001.html>