D9699: Keep fullscreen windows in active layer based on transients not the group

[Thomas Lübking]

luebking added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  The original implementation based the fullscreen status on the stack position of the window (ie. whenever a window would rise above the plain stack position of the FS window, it would loose the FS status, ie. top layer)
  The result was iirc that random notifications would not only show up but also de-fullscreen the window and also virtual desktop switches would constantly kill the FS state.
  
  The group/transient thing was iirc a "make this simpler" thing (assuming the group would be sufficient again, since the switch from stack => active killed the major issues and annoyances that the stack selection brought)
  
  Notice that the new patch does not cover the case of layered transient windows (which iirc was an issue with dolphin at the time, but pls don't nail me on that)
  
  The code in place is certainly wrong, but none of the linked commits actually removed the group check that was used in https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 (the other two commits predate that one)

REPOSITORY
  R108 KWin

BRANCH
  fullscreen-transient-not-group

REVISION DETAIL
  https://phabricator.kde.org/D9699

To: graesslin, #kwin, #plasma, romangg
Cc: luebking, romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180106/4548ab1c/attachment.html>