D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

Henrik Fehlauer noreply at phabricator.kde.org
Fri Jan 5 18:46:05 UTC 2018


rkflx added a comment.


  In https://phabricator.kde.org/D9627#186592, @ngraham wrote:
  
  > FWIW, I rather prefer abstract words instead of numbers, since then we have more freedom to tweak the numbers under the hood in the future. The actual numbers aren't important enough to show to the user IMHO. And if we do expose the number, people will eventually ask for a spinbox to precisely input arbitrary values, and we'll be back to where we started from. :-)
  
  
  Exactly my thoughts.
  
  As we now have three comboboxes (sizes of shadow, border, window buttons) all with slightly different options, we could think about unifying these, both in the number of options (not too many) and the wording (no "normal"/"default" etc.). For example Tiny > Small > Medium > Large > Huge plus special cases (e.g. No [Side] Borders). Different patch, of course. Thoughts?
  
  ---
  
  > Small is the old default value for people who preferred that.
  
  Works for the menu, but the window shadow is not as before for me. Maybe insert Tiny with 6px + 6px?
  
  As for the rest, it's working well for me (did not look at the code, though). Thank you Hugo + Nate!
  
  @ngraham BTW, how did you solve the `.so` problem in the end?

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180105/5dc76162/attachment.html>


More information about the Plasma-devel mailing list