D9627: Reduce menu shadows to half the size of the window shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi 
  thanks for the patch !
  
  ... see inline comment.
  Also note that to more or less match the different scales shown in your original screenshot, you would need a 0.25% scale (or even 0.20%) rather than 0.5% 
  But I am also fine with the current choice.

INLINE COMMENTS

> breezeshadowhelper.cpp:512
>          // metrics
> -        const int shadowSize = StyleConfigData::shadowSize()*12/16;
> +        const int shadowSize = StyleConfigData::shadowSize()*8/16;
>          const int shadowOffset = qMax( shadowSize/2, Metrics::Shadow_Overlap*2 );

There are in fact two places in this code where the shadow size is set. the same scale factor should be used at both places. Easiest is probably to make it a static variable like

static const qreal shadowSizeScale = 0.5; at the top of the file and use it in the two places where necessary.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180103/befc3766/attachment.html>