<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9627" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hi <br />
thanks for the patch !</p>

<p>... see inline comment.<br />
Also note that to more or less match the different scales shown in your original screenshot, you would need a 0.25% scale (or even 0.20%) rather than 0.5% <br />
But I am also fine with the current choice.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9627#inline-43572" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezeshadowhelper.cpp:512</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// metrics</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">shadowSize</span> <span style="color: #aa2211">=</span> <span class="n">StyleConfigData</span><span style="color: #aa2211">::</span><span class="n">shadowSize</span><span class="p">()</span><span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span style="color: #601200"><span class="bright">12</span></span><span style="color: #aa2211">/</span><span style="color: #601200">16</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">shadowSize</span> <span style="color: #aa2211">=</span> <span class="n">StyleConfigData</span><span style="color: #aa2211">::</span><span class="n">shadowSize</span><span class="p">()</span><span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span style="color: #601200"><span class="bright">8</span></span><span style="color: #aa2211">/</span><span style="color: #601200">16</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">shadowOffset</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span> <span class="n">shadowSize</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">,</span> <span class="n">Metrics</span><span style="color: #aa2211">::</span><span class="n">Shadow_Overlap</span><span style="color: #aa2211">*</span><span style="color: #601200">2</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There are in fact two places in this code where the shadow size is set. the same scale factor should be used at both places. Easiest is probably to make it a static variable like</p>

<p style="padding: 0; margin: 8px;">static const qreal shadowSizeScale = 0.5; at the top of the file and use it in the two places where necessary.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9627" rel="noreferrer">https://phabricator.kde.org/D9627</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Breeze, apol, hpereiradacosta<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>