D9549: Horizontally center shadows and make them bigger

Hugo Pereira Da Costa noreply at phabricator.kde.org
Mon Jan 1 16:46:44 UTC 2018


hpereiradacosta added a comment.


  Hello, my take on the following suggestions:
  
  > TL;DR, I'd like to see:
  > 
  > - menu shadow size not affected by config dialog
  
  I think menu shadow size should be
  
  - smaller than window size
  - scale with the window size (controlled by the spinbox), so that ratio between the two is fixed, rather than be fixed (otherwise you can end up with the weird situation) were menu shadow is larger than window shadow.
  
  this was in fact the idea behind the possibly buggy original code.
  
  > - increased maximum value
  
  Agreed
  
  > - option to disable centering, RTL aware
  
  It was agreed in the other patch by VDG that there should not be an option, and that one should decide on one design or the other. From this patch the agreement seems to be moving towards centered shadowed.
  
  > - fix HiDPI window shadow size
  
  Definitly, though that might require some interactions with e.g. kwin. 
  Should be a different patch anyway.
  
  Best,
  
  Hugo

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180101/b3f15f42/attachment.html>


More information about the Plasma-devel mailing list