<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9549" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hello, my take on the following suggestions:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>TL;DR, I'd like to see:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">menu shadow size not affected by config dialog</li>
</ul></blockquote>
<p>I think menu shadow size should be</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">smaller than window size</li>
<li class="remarkup-list-item">scale with the window size (controlled by the spinbox), so that ratio between the two is fixed, rather than be fixed (otherwise you can end up with the weird situation) were menu shadow is larger than window shadow.</li>
</ul>
<p>this was in fact the idea behind the possibly buggy original code.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">increased maximum value</li>
</ul></blockquote>
<p>Agreed</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">option to disable centering, RTL aware</li>
</ul></blockquote>
<p>It was agreed in the other patch by VDG that there should not be an option, and that one should decide on one design or the other. From this patch the agreement seems to be moving towards centered shadowed.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">fix HiDPI window shadow size</li>
</ul></blockquote>
<p>Definitly, though that might require some interactions with e.g. kwin. <br />
Should be a different patch anyway.</p>
<p>Best,</p>
<p>Hugo</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9549" rel="noreferrer">https://phabricator.kde.org/D9549</a></div></div><br /><div><strong>To: </strong>ngraham, abetts, hpereiradacosta, VDG, Breeze, alake<br /><strong>Cc: </strong>rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>