D10901: Add "move to device" functionality to hamburger menu

David Rosca noreply at phabricator.kde.org
Tue Feb 27 20:50:02 UTC 2018


drosca added a comment.


  +1. No more code comments.
  
  Just a note, we can't guarantee that audio is actually playing from that stream.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:338
> `sinkView.model.count > 1` -> `sinkView.count`

Sorry about this comment, it's nonsense. It was fine in your fist diff.

It must check `> 1` not just `> 0`.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180227/91703039/attachment.html>


More information about the Plasma-devel mailing list