D10901: Add "move to device" functionality to hamburger menu
Christian
noreply at phabricator.kde.org
Tue Feb 27 20:17:32 UTC 2018
Fuchs updated this revision to Diff 28214.
Fuchs added a comment.
Updated the text, tried to merge the code blocks. Due to most of it happening in a for loop depending on the type, this was not possible in a sane way without having a helper method created.
Personally I think legibility goes a tad bit down. If made easier to read, performance would go suffer (e.g. executing parts of it despite it not going to be shown anyway).
I also think the .count variant is a bit easier to read, but take whichever you prefer.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10901?vs=28212&id=28214
REVISION DETAIL
https://phabricator.kde.org/D10901
AFFECTED FILES
applet/contents/ui/ListItemBase.qml
To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180227/b65aaa3c/attachment.html>
More information about the Plasma-devel
mailing list