D10440: Support modifier mouse/scroll action on internal decorated windows

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In D10440#213112 <https://phabricator.kde.org/D10440#213112>, @romangg wrote:
  
  > Looks fine, but making this behavior dependent on `isDecorated` seems a bit hacky to me. Wouldn't be a separate property for this better? Are all internal windows without decoration not movable? What if we want to do it this way at some point in the future? We just shouldn't forget about this check here then.
  
  
  KWin internal windows are a bit special. Traditionally KWin was not able to manage it's own windows which means on X11 they were override redirect. Due to that they are not movable. The first ever internal window which is not falling under the constraints is the DebugConsole. But also only on Wayland. On X11 it has the same restrictions as on Wayland. Due to the restrictions for internal windows I consider it as highly unlikely that we will extend this in future. The main difference between a normal internal window and the DebugConsole internal window is that it is decorated. Other internal windows which are not decorated are also not going to be movable. What we currently have are things like the OSD, Overlay, etc. All of them not movable. "Real" windows are normally done through spawning a dedicated child process (examples: window killer, dialog for fullscreen windows, etc.). This is probably also not going to change.
  
  So yes the whole thing is kind of hacky, but I think it is acceptable.

REPOSITORY
  R108 KWin

BRANCH
  modifier-click-scroll-decorated-internal-window-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10440

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180225/a1d3f4fb/attachment.html>