D10697: Make the badge text readable on dark color schemes
Milian Wolff
noreply at phabricator.kde.org
Tue Feb 20 20:24:07 UTC 2018
mwolff created this revision.
mwolff added reviewers: broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mwolff requested review of this revision.
REVISION SUMMARY
The background color should not be used for the foreground text
color, I believe. The background color is set to theme.highlightColor,
so use theme.highlightedTextColor for the foreground. This ensures
the text is readable on a dark color scheme.
TEST PLAN
unreadable text before, readable now
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10697
AFFECTED FILES
applets/taskmanager/package/contents/ui/Badge.qml
To: mwolff, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180220/d2ca4b3d/attachment.html>
More information about the Plasma-devel
mailing list