D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)
Nathaniel Graham
noreply at phabricator.kde.org
Wed Feb 14 14:21:00 UTC 2018
ngraham added a comment.
Going up from the 0.71 magic number to the 0.85 magic number would make the clock bigger than it currently is, no? Can you supply a screenshot of how this works now at standard size, increased size, and witha high-DPI display?
Since magic numbers are bad, and we already have one for the clock, it does seem reasonable to replace it with a constant of some sort that we can re-use, for example with the notification icons as you're proposing. Making it user-configurable seems like unnecessary overkill to me though.
@davidedmundson, what do you think about that plan? We'd get rid of the existing magic number, which would be nice, right?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10487
To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180214/a29b31c2/attachment.html>
More information about the Plasma-devel
mailing list