D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> OverlaySheet.qml:270
>              width: root.contentItem.implicitWidth <= 0 ? mainItem.width : Math.max(mainItem.width/2, Math.min(mainItem.width, root.contentItem.implicitWidth))
> -            height: scrollView.flickableItem && root.contentItem.hasOwnProperty("contentY") ? scrollView.flickableItem.contentHeight + headerHeight : (root.contentItem.height + topPadding + bottomPadding + Units.iconSizes.medium + Units.gridUnit)
> +            height: scrollView.flickableItem && root.contentItem.hasOwnProperty("contentY") ? scrollView.flickableItem.contentHeight + headerHeight : (root.contentItem.height + Units.gridUnit * 2)
>              Item {

Does this mean that setting the topPadding and bottomPadding to 0 would make this empty space go away?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180214/fbe4f53c/attachment.html>