<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10502" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10502#inline-49665" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OverlaySheet.qml:270</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">width:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">implicitWidth</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">mainItem.width :</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">mainItem</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">,</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">mainItem</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">implicitWidth</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">height:</span> <span style="color: #004012">scrollView</span><span class="p">.</span><span style="color: #004012">flickableItem</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">hasOwnProperty</span><span class="p">(</span><span style="color: #766510">"contentY"</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">scrollView</span><span class="p">.</span><span style="color: #004012">flickableItem</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">headerHeight :</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span style="color: #004012"><span class="bright">topPadding</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">bottomPadding</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Units</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">iconSizes</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">medium</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">gridUnit</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">height:</span> <span style="color: #004012">scrollView</span><span class="p">.</span><span style="color: #004012">flickableItem</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">hasOwnProperty</span><span class="p">(</span><span style="color: #766510">"contentY"</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">scrollView</span><span class="p">.</span><span style="color: #004012">flickableItem</span><span class="p">.</span><span style="color: #004012">contentHeight</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">headerHeight :</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">contentItem</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">gridUnit<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #004012">Item</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does this mean that setting the topPadding and bottomPadding to 0 would make this empty space go away?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10502" rel="noreferrer">https://phabricator.kde.org/D10502</a></div></div><br /><div><strong>To: </strong>ngraham, Kirigami, apol<br /><strong>Cc: </strong>plasma-devel, apol, davidedmundson, mart, hein<br /></div>