D10480: align checkable widgets in menu items

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Feb 13 12:50:01 UTC 2018


zzag created this revision.
zzag added reviewers: Breeze, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Some icons in menus have small internal padding. In addition to that,
  `PM_SmallIconSize` is smaller than space left to icons, which results
  in adding space around icons. This all "shifts" check boxes and
  radio buttons to the left side.
  
  So, check boxes and radio buttons have to be centered between icon/text
  and the left border. (we can't rely on margins)
  
  Also, it fixes double space between check boxes and text when icons
  in menus are disabled. (mostly, as a side effect)

TEST PLAN
  - open a context menu with icons and check boxes

REPOSITORY
  R31 Breeze

BRANCH
  center-checkbox

REVISION DETAIL
  https://phabricator.kde.org/D10480

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180213/c512c1a4/attachment.html>


More information about the Plasma-devel mailing list