<table><tr><td style="">zzag created this revision.<br />zzag added reviewers: Breeze, VDG, hpereiradacosta.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />zzag requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10480" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Some icons in menus have small internal padding. In addition to that,<br />
<tt style="background: #ebebeb; font-size: 13px;">PM_SmallIconSize</tt> is smaller than space left to icons, which results<br />
in adding space around icons. This all "shifts" check boxes and<br />
radio buttons to the left side.</p>
<p>So, check boxes and radio buttons have to be centered between icon/text<br />
and the left border. (we can't rely on margins)</p>
<p>Also, it fixes double space between check boxes and text when icons<br />
in menus are disabled. (mostly, as a side effect)</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">open a context menu with icons and check boxes</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>center-checkbox</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10480" rel="noreferrer">https://phabricator.kde.org/D10480</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kstyle/breeze.h<br />
kstyle/breezestyle.cpp</div></div></div><br /><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>