D10438: reserve space for checkable widgets in menu items

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Feb 13 00:12:14 UTC 2018


zzag added a comment.


  @anemeth here are menu items with centered check boxes and radio buttons:
  
  F5708483: aligned-1.png <https://phabricator.kde.org/F5708483>
  
  F5708505: aligned-2.png <https://phabricator.kde.org/F5708505>
  
  F5708523: aligned-4.png <https://phabricator.kde.org/F5708523>
  
  it's still not perfectly aligned because some icons have inner padding. So, that's the best what I can do.
  
  Also, I've increased `MenuItem_MarginWidth` to `4`(according to @fabianr's comment).
  
  F5708489: aligned-3.png <https://phabricator.kde.org/F5708489>
  
  That's all.
  
  ---
  
  I'm not sure whether these changes should come with this diff or maybe I should create another diff which "fixes" alignment of check boxes. @ngraham, @hpereiradacosta, @abetts what do you think?
  
  ---
  
  Also, is there a bug report about missing shortcut hints when icons in menus are disabled?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180213/65bb9e04/attachment.html>


More information about the Plasma-devel mailing list