D10438: reserve space for checkable widgets in menu items

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Feb 12 20:07:44 UTC 2018


zzag added a comment.


  In D10438#205139 <https://phabricator.kde.org/D10438#205139>, @anemeth wrote:
  
  > Maybe you could align the checkbox better?
  >  The numbers are pixels
  >  F5708060: aaaaaaaaaaaaa.png <https://phabricator.kde.org/F5708060>
  
  
  I don't really think this diff should mess with margins. I'd would like to leave it as it is right now. Maybe another diff should be created regarding checkbox spacing.
  
  ---
  
  Explanation behind numbers:
  
  - 4: it should be 3(marginwidth) + 1(measurement error?)
  - 9: 4(itemspacing) + 1 + 2[(20 - 16) / 2] + 2(icons have padding)
  - 8: 2[(20 - 16) / 2] + 4(itemspacing) + 1 + 1(measurement error?)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180212/fa6fd1ee/attachment.html>


More information about the Plasma-devel mailing list