D7087: Add "Copy Info" button to the About System KCM

[Dominik Haumann]

dhaumann added a comment.


  All the keys in collectedData are not properly translated. As such, creating a final string out of this is not translation friendly.
  
  Given you seem to know exactly what data is going to be exported, you could also create a small helper class that gets filled.
  This way, you'd have all data at hand when you want to copy, and you have 100% control about how you create your strings, e.g.:
  i18n("Processors: %1", processorCount);
  
  If you use i18n("Processors") + ":" + QString::number(processorCount), then this cannot be properly translated into all languages.
  
  Rule of thumb: One entire sentence must ALWAYS be in exactly ONE and the SAME i18n() call. Otherwise, translation is pretty much ALWAYS broken :-)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180204/94759ffa/attachment.html>