<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7087" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>All the keys in collectedData are not properly translated. As such, creating a final string out of this is not translation friendly.</p>
<p>Given you seem to know exactly what data is going to be exported, you could also create a small helper class that gets filled.<br />
This way, you'd have all data at hand when you want to copy, and you have 100% control about how you create your strings, e.g.:<br />
i18n("Processors: %1", processorCount);</p>
<p>If you use i18n("Processors") + ":" + QString::number(processorCount), then this cannot be properly translated into all languages.</p>
<p>Rule of thumb: One entire sentence must ALWAYS be in exactly ONE and the SAME i18n() call. Otherwise, translation is pretty much ALWAYS broken :-)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7087" rel="noreferrer">https://phabricator.kde.org/D7087</a></div></div><br /><div><strong>To: </strong>gregormi, ngraham<br /><strong>Cc: </strong>dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br /></div>